[Gs-code-review] Post commit submission of minor pdfformaterror
ray at artifex.com
Thu Feb 14 15:05:49 PST 2002
Dan Coby wrote:
> Looks good but a few small questions.
> 1. Why did you drop the "an" in "File encountered an ' ' error", pdf_draw.ps
> line 861?
Well, it looked OK for 'undefined', but didn't look as good for 'rangecheck'
**** File encountered an 'rangecheck' error while processing an image
Now it is consistently marginal grammar:
**** File encountered 'undefined' error while processing an image
**** File encountered 'rangecheck' error while processing an image
> 2. In general, you put in explicit \n for line feeds. (Which I like.)
> Yet you left the line feeds in printproducer and printrepaired. Why?
I just didn't bother to change them. As I recall, there were several
places that used the embedded EOL. (I also don't like it -- it is hard
> 3. Line 156 of pdf_sec.ps does not contain a space after "****".
I'vw corrected this and the items you mention from #2 above and also
fixed a couple of pdfformaterror messages I missed.
More information about the gs-code-review