[Gs-code-review] porting the regression test tool to Windows
L. Peter Deutsch
ghost at aladdin.com
Tue Feb 19 07:39:15 PST 2002
>> I like these changes. Please delay implementing them until after Jack
>> has approved the new toolbin/tests directory, so that the changes can be
>> made to the new files.
> It's too hard for me to wait a weeks before applying each patch.
> Too many local versions. Too big delays and too slow development.
> I'm tired to accommodate obsolete patches.
> I've committed it, while my patch corresponds to the repository state.
> I think the renaming a directory isn't complicated after this.
I did not see any message on gs-code-review indicating that your patches had
been approved. (I am not your official reviewer.) Did I miss it?
I too dislike waiting a week or sometimes longer to apply patches that I
have posted to gs-code-review, especially if I am working on more than one
project, but I consider this a reasonable price for having the review
process work well. Part of the "social contract" for gs-code-review is that
reviewers will review patches quickly. If a patch I have posted is not
reviewed within 1 week, I send a reminder to Raph, who is my official
Since your patches affect the same files that Jack and I have been working
on, I have to handle the merge process. Fortunately, the patches are small,
so even though about half of them create conflicts that I have to fix
manually, it won't take me a lot of time.
In the future, please wait for review before committing patches.
L. Peter Deutsch | Aladdin Enterprises | 203 Santa Margarita Ave.
ghost at aladdin.com | http://www.aladdin.com | Menlo Park, CA 94025
The future of software is at http://www.opensource.org
More information about the gs-code-review